Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.2-release #50

Merged
merged 2 commits into from
Dec 8, 2023
Merged

v0.3.2-release #50

merged 2 commits into from
Dec 8, 2023

Conversation

catherinebirney
Copy link
Collaborator

@catherinebirney catherinebirney commented Dec 8, 2023

add ability to include a version and/or hash when downloading data commons files

In flowsa (and I assume other packages), we were not able to specify a file version and/or hash when downloading files from data commons. For example:
flowsa.collapse_FlowBySector("GHG_national_2018_m2_v2.0.0_a8c5929",download_FBS_if_missing=True)
was failing. We could only run:
flowsa.collapse_FlowBySector("GHG_national_2018_m2",download_FBS_if_missing=True)

This PR modifies how files are found on data commons so users can specify versions/hashes

@catherinebirney
Copy link
Collaborator Author

@bl-young We don't have any impending proposed changes to esupy, do we? If not, I'll release a new esupy version with this change

@catherinebirney catherinebirney changed the base branch from main to v0.3.2-release December 8, 2023 19:07
@catherinebirney catherinebirney changed the title add ability to include a version and/or hash when downloading data commons files v0.3.2-release Dec 8, 2023
@bl-young
Copy link
Collaborator

bl-young commented Dec 8, 2023

I think i had intended to do a v0.3.2 release after: #49 but I did not

But that should be fine.

However note that pinning to flowsa v1.3.2 for HIO will not allow us to reference this commit. So i'm not sure what to do about that.

@bl-young
Copy link
Collaborator

bl-young commented Dec 8, 2023

And are we sure this is an issue under current cases or only in old flowsa?

@catherinebirney
Copy link
Collaborator Author

And are we sure this is an issue under current cases or only in old flowsa?

It is an issue in v2.0.0 - I'm not sure in which version of flowsa it became an issue, it's possible the older versions of flowsa did not have this problem.

@bl-young
Copy link
Collaborator

bl-young commented Dec 8, 2023

Oh I see - right so this is specifically when downloading the file, as currently we can access specific files via their git hash if they are local already.

@catherinebirney
Copy link
Collaborator Author

Correct - we don't need to worry about this download issue in older versions of flowsa because if it is an issue we can manually download from Data Commons

@catherinebirney catherinebirney merged commit 6249841 into v0.3.2-release Dec 8, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants